fix: avoid cross compiling on same architecture #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raylrui
approved these changes
Mar 18, 2025
victorskl
approved these changes
Mar 18, 2025
|
Well done figuring this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to failing filemanager builds on CodeBuild: https://github.com/umccr/orcabus/actions/runs/13912874550/job/38930505126?pr=912
I think this is an upstream issue - the
RustFunctionuses zig underneath to cross compile because the native cross compilation usingcargois not as convenient. This only occurs on some targets and I think this issue is related: ziglang/zig#23052Either way, this is only affecting compilation with zig to
aarch64from an arm64 machine. For that case, it's better to just use cargo directly as there is no cross compilation.Changes
cargo-zigbuildand just using cargo directly.