Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library and Samplesheet Linking for Existing Sequence Runs #889

Merged
merged 7 commits into from
Mar 19, 2025

Conversation

raylrui
Copy link
Contributor

@raylrui raylrui commented Mar 5, 2025

Solve: #888

Current Process for processing library linking for existing sequence runs:

  1. upload library linking files and samplesheet linking files into the temp bucket created for sequence enrichment. (linking files will have the orcabus_id/instrument_id, library collections/samplesheet json mappping)
  2. trigger the lambda function with target file(key) name as input. It will the file and load the record into database by batch insertion.

@raylrui raylrui added the feature New feature label Mar 5, 2025
@raylrui raylrui self-assigned this Mar 5, 2025
@raylrui raylrui marked this pull request as ready for review March 17, 2025 23:26
@raylrui raylrui changed the title Library Linking for Existing Sequence Runs Library and Samplesheet Linking for Existing Sequence Runs Mar 18, 2025
@raylrui raylrui requested review from reisingerf and victorskl March 18, 2025 21:55
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Minor comment, pls unit test some of these later. Okay for now as first pass.

@raylrui
Copy link
Contributor Author

raylrui commented Mar 18, 2025

Minor comment, pls unit test some of these later. Okay for now as first pass.

sure, I will add some. And Couple of testing in dev have already conducted, it working fine. It will won't make any breaking changes as it just has insert operation. And I think we can remove it after all history record building finishing.

@raylrui raylrui added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit d26d360 Mar 19, 2025
6 checks passed
@raylrui raylrui deleted the feat/srm-library-linking-for-existing-runs branch March 19, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequence run manager: script (lambda) for creating library linking for previous sequence runs
3 participants