721 property added for rel to allow #814
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to the following uui components to add the option for a rel property to allow it to be set by the component rather than just relying on the target="_blank"
uui-button
uui-button-inline - not sure if this is being maintained as the stories and test don't map 100% to the compoment
uui-card
uui-card-block-type
uui-card-content-node
uui-card-media
uui-card-user
uui-menu-item
uui-ref-node
uui-tabs
To ensure it doesn't effect existing links with a target _blank I have left the original logic in to set it to what was previously there but allow it to be overidden by rel prop.
Types of changes
Motivation and context
Proposed fix for issue #721
Gived the ability to define the rel on a link
Picked this up as my first contribution to Umbraco
How to test?
Within the following components there is a new prop for rel if you set the rel the value will be set on the anchor tag.
uui-button
uui-button-inline - not sure if this is being maintained as the stories and test don't map 100% to the compoment
uui-card
uui-card-block-type
uui-card-content-node
uui-card-media
uui-card-user
uui-menu-item
uui-ref-node
uui-tabs
Screenshots (if appropriate)
Checklist