Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

721 property added for rel to allow #814

Open
wants to merge 4 commits into
base: v1/contrib
Choose a base branch
from

Conversation

AndyLongShout
Copy link

Description

Updates to the following uui components to add the option for a rel property to allow it to be set by the component rather than just relying on the target="_blank"

uui-button
uui-button-inline - not sure if this is being maintained as the stories and test don't map 100% to the compoment
uui-card
uui-card-block-type
uui-card-content-node
uui-card-media
uui-card-user
uui-menu-item
uui-ref-node
uui-tabs

To ensure it doesn't effect existing links with a target _blank I have left the original logic in to set it to what was previously there but allow it to be overidden by rel prop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

Proposed fix for issue #721
Gived the ability to define the rel on a link
Picked this up as my first contribution to Umbraco

How to test?

Within the following components there is a new prop for rel if you set the rel the value will be set on the anchor tag.

uui-button
uui-button-inline - not sure if this is being maintained as the stories and test don't map 100% to the compoment
uui-card
uui-card-block-type
uui-card-content-node
uui-card-media
uui-card-user
uui-menu-item
uui-ref-node
uui-tabs

Screenshots (if appropriate)

image
image

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • [x ] I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.

Copy link

Hi there @AndyLongShout, thank you for this contribution! 👍

While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link

sonarcloud bot commented Jun 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
9.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant