feat(uui-card): Adds checkbox for selection #1138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new checkbox selection feature to various card components within the UUI library. Key changes include:
- Adding a dependency on uui-checkbox and importing it in uui-card.
- Implementing a renderCheckbox() method in uui-card and integrating it into the derived card components (User, Media, Content Node, and Block Type).
- Updating the corresponding Storybook stories to demonstrate selectable card variants.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/uui-card/tsconfig.json | Added reference to uui-checkbox to enable checkbox feature. |
| packages/uui-card/package.json | Added dependency on uui-checkbox. |
| packages/uui-card/lib/uui-card.element.ts | Introduced renderCheckbox() and imported uui-checkbox. |
| packages/uui-card-user/* | Integrated renderCheckbox() into card user element and updated story. |
| packages/uui-card-media/* | Integrated renderCheckbox() and updated story; removed "width: 100%" from #content CSS. |
| packages/uui-card-content-node/* | Integrated renderCheckbox() and updated styling for #select-checkbox. |
| packages/uui-card-block-type/* | Integrated renderCheckbox() and updated story configuration. |
Comments suppressed due to low confidence (1)
packages/uui-card-media/lib/uui-card-media.element.ts:210
- The removal of 'width: 100%;' from the #content styling could impact layout consistency compared to other card components. Consider confirming that this change aligns with the intended design and layout behavior for media cards.
display: flex;
|
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-1138.westeurope.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the proposed implementation of displaying a checkbox on a Media Card in the Umbraco CMS backoffice, umbraco/Umbraco-CMS#19616, we agreed that this feature should be done natively across cards in the UUI library.
Types of changes
Motivation and context
As a UX enhancement, a checkbox has been added to selectable cards to provide a visual indicator that the card can be selected, (rather than attempting to click the card's border).
How to test?
Important
Please note, the checkbox will only be available when the card is in
selectablemode.The checkbox will only appear when the card is focused (or being hovered).
In the Storybook, for a Media Card, does toggling the checkbox perform a select/deselect action? Does clicking the card's border toggle the checkbox? Does keyboard navigation work with the select/deselect interaction?
The hover-over checkbox has been added to the following card types: Block Type Card, Content Node Card, Media Card and User Card. It has not been added to the base
uui-card.Screenshots (if appropriate)
Recording.2025-06-30.185647.mp4