fix: move extra export to bottom

ulule · Jan 19, 2024 · bf82328 · bf82328
1 parent db593cf
commit bf82328
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/cmd/mover/main.go b/cmd/mover/main.go
@@ -39,7 +39,7 @@ func main() {
 	} else {
 		logger, _ = zap.NewProduction()
 	}
-	// nolint:errcheck
+	//nolint:errcheck
 	defer logger.Sync()
 
 	var cfg config.Config

diff --git a/etl/engine.go b/etl/engine.go
@@ -4,7 +4,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"os"
 	"path"
 	"strings"
 
@@ -114,22 +114,22 @@ func (e *Engine) Extract(ctx context.Context, outputPath, query string) error {
 		return fmt.Errorf("unable to extract %s (query %s): %w", tableName, query, err)
 	}
 
+	for tableName := range cache {
+		if err := e.extract(ctx, outputPath, e.schema[tableName], cache[tableName]); err != nil {
+			return fmt.Errorf("unable to extract rows from table %s: %w", tableName, err)
+		}
+	}
+
 	for i := range e.config.Extra {
 		tableName := e.config.Extra[i].TableName
 		query, _ := lk.Select(lk.Raw("*")).
 			From(tableName).Query()
-		cache, err = extractor.Handle(ctx, e.schema[tableName], query)
+		_, err = extractor.Handle(ctx, e.schema[tableName], query)
 		if err != nil {
 			return fmt.Errorf("unable to extract %s (query %s): %w", tableName, query, err)
 		}
 	}
 
-	for tableName := range cache {
-		if err := e.extract(ctx, outputPath, e.schema[tableName], cache[tableName]); err != nil {
-			return fmt.Errorf("unable to extract rows from table %s: %w", tableName, err)
-		}
-	}
-
 	return nil
 }
 
@@ -155,7 +155,7 @@ func (e *Engine) extract(ctx context.Context, outputPath string, schema config.S
 	}
 
 	filePath := path.Join(outputPath, table.Name+extensionFormat)
-	if err := ioutil.WriteFile(filePath, output, 0644); err != nil {
+	if err := os.WriteFile(filePath, output, 0644); err != nil {
 		return fmt.Errorf("unable to write JSON output to %s: %w", filePath, err)
 	}
 

diff --git a/etl/loader.go b/etl/loader.go
@@ -4,7 +4,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"os"
 	"path/filepath"
 	"strings"
@@ -58,7 +58,7 @@ func (l *loader) loadFile(ctx context.Context, filePath string) error {
 	}
 	defer file.Close()
 
-	content, err := ioutil.ReadAll(file)
+	content, err := io.ReadAll(file)
 	if err != nil {
 		return fmt.Errorf("unable to read file %s: %w", filePath, err)
 	}