-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update __init__.py #1542
base: master
Are you sure you want to change the base?
Update __init__.py #1542
Conversation
Delete the line that breaks the ability to choose whether to use Chrome's "--no-sandbox" argument or not. That functionality is supposed to be achieved through "no_sandbox" argument in the "__init__" method of the UC's Chrome class.
Many people are frustrated by the common issue on Windows: UC is eating up all the resources because of zombie/dangling uc.Chrome(driver_executable_path=driver_executable_path, options=options, user_data_dir=user_data_dir, no_sandbox=False, user_multi_procs=True, use_subprocess=False) Users say that undetected-chromedriver doesn't work without |
Remove some comments.
I am on Windows 10, and I can confirm setting this to |
it helps, no_sandbox=False i used. And dont use driver.quit() or driver.close(), it will automatically quit |
Delete the line that breaks the ability to choose whether to use Chrome's "--no-sandbox" argument or not. That functionality is already, and supposed to be achieved through "no_sandbox" argument in the "init" method of the UC's Chrome class.
It may solve these issues: #1507 #1445 #1270
@ultrafunkamsterdam you should apply this commit as soon as possible, so people can use UC on Windows safely.