New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed comparison error #309

Open

noguchi-k wants to merge 1 commit into ultimatesource:master from noguchi-k:bugfix

noguchi-k commented Mar 23, 2020

Hello.I found an error building denovogear, so I suggest sourse fixes.
Could you check if it is the right fix?

error

  >> 162    newmat6.cpp:431:13: error: ordered comparison between pointer and z
            ero ('int *' and 'int')                                            
     163       if (indx > 0) { delete [] indx; indx = 0; }
     164           ~~~~ ^ ~

I changed comparison from indx > 0 to indx != NULL


          fixed comparison error

noguchi-k mentioned this pull request

denovogear: fixed comparison error spack/spack#15638

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet