Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof Refactoring #671

Merged
merged 97 commits into from
Aug 20, 2024
Merged

Proof Refactoring #671

merged 97 commits into from
Aug 20, 2024

Commits on Nov 27, 2023

  1. Configuration menu
    Copy the full SHA
    60055de View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a30dbb1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d72b396 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Configuration menu
    Copy the full SHA
    62f36a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c5a3332 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. cherry-pick Floyd-Hoare changes from wip/dk/empire-owicki

    These changes allow computing Floyd/Hoare annotations for
    product automata of concurrent programs.
    maul-esel committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    76a50a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c4dc82 View commit details
    Browse the repository at this point in the history
  3. move Floyd/Hoare handling

    BasicCegarLoop should not refer to Floyd/Hoare proofs, let NwaCegarLoop
    handle this. Also, CEGAR loops refer directly to Hoare annotation states,
    not IcfgLocations.
    maul-esel committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    a87a7c0 View commit details
    Browse the repository at this point in the history
  4. HoareAnnotationFragments: rely on supplied hoareAnnotationStates

    Do not check the setting again, the caller should supply the appropriate states.
    maul-esel committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    224148a View commit details
    Browse the repository at this point in the history
  5. move HoareAnnotationPositions to its own file

    Also define their semantics in the class itself,
    rather than in some utility class.
    maul-esel committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    0cd9943 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c9454fe View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c3557f2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    94a263c View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Configuration menu
    Copy the full SHA
    05c0479 View commit details
    Browse the repository at this point in the history
  2. specialize return type

    maul-esel committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    87eb079 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3f177bc View commit details
    Browse the repository at this point in the history
  4. rename method

    maul-esel committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    276e2b5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d17f6f0 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    1604cae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f4c56b View commit details
    Browse the repository at this point in the history
  3. add Validity::and method

    maul-esel committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    f2110d5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    eea7867 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Configuration menu
    Copy the full SHA
    2032d1f View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. Configuration menu
    Copy the full SHA
    54d3723 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Configuration menu
    Copy the full SHA
    b4501bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b37babc View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Configuration menu
    Copy the full SHA
    9080e3b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eb2b75c View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. missing license headers

    maul-esel committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    87b555a View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. continue refactoring

    maul-esel committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    0aaec9c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f62a22f View commit details
    Browse the repository at this point in the history
  3. fix NPE

    maul-esel committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    2c18645 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2bbf6a2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    92aeb31 View commit details
    Browse the repository at this point in the history
  6. some doc comments

    maul-esel committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    6f6212a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    646c763 View commit details
    Browse the repository at this point in the history
  8. better method name

    maul-esel committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    d48c12e View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Configuration menu
    Copy the full SHA
    982513e View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Configuration menu
    Copy the full SHA
    a7c5404 View commit details
    Browse the repository at this point in the history
  2. remove unused method

    maul-esel committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    177732a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ed90216 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Configuration menu
    Copy the full SHA
    50509a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ffa4bff View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aa874c3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    66b37b6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5a53242 View commit details
    Browse the repository at this point in the history
  6. minor simplifications

    maul-esel committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    38d3fd1 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. remove unused param

    maul-esel committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    6f0885e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c943d41 View commit details
    Browse the repository at this point in the history
  3. small simplification

    maul-esel committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    c9b4873 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d1c4f2c View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Merge branch 'dev' into wip/dk/proof-refactoring

    # Conflicts:
    #	trunk/source/InvariantSynthesis/src/de/uni_freiburg/informatik/ultimate/plugins/generator/invariantsynthesis/InvariantSynthesisStarter.java
    #	trunk/source/Library-ModelCheckerUtils/src/de/uni_freiburg/informatik/ultimate/lib/modelcheckerutils/smt/predicates/PredicateUtils.java
    #	trunk/source/Library-Proofs/src/de/uni_freiburg/informatik/ultimate/lib/proofs/floydhoare/HoareAnnotationComposer.java
    #	trunk/source/TraceAbstraction/src/de/uni_freiburg/informatik/ultimate/plugins/generator/traceabstraction/TraceAbstractionStarter.java
    #	trunk/source/TraceAbstraction/src/de/uni_freiburg/informatik/ultimate/plugins/generator/traceabstraction/TraceAbstractionUtils.java
    #	trunk/source/TraceAbstraction/src/de/uni_freiburg/informatik/ultimate/plugins/generator/traceabstraction/predicates/HoareAnnotationChecker.java
    maul-esel committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    26b3c0d View commit details
    Browse the repository at this point in the history
  2. fix typo

    maul-esel committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    a67f538 View commit details
    Browse the repository at this point in the history
  3. deprecate class

    maul-esel committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    a1f6fff View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6d4caa8 View commit details
    Browse the repository at this point in the history
  5. fix typo

    maul-esel committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    098a0b3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7b35f9c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    806e1ff View commit details
    Browse the repository at this point in the history
  8. update some TODO comments

    maul-esel committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    38790be View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    18f2a4f View commit details
    Browse the repository at this point in the history
  10. simplify type signatures

    maul-esel committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    f43013b View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. separate proof production from postprocessing

    CEGAR loops decide which kinds of proofs they provide and how.
    Disentangle possible postprocessing of proofs from CEGAR loops
    and proof production.
    maul-esel committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    a5e34d2 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    d3528af View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Merge branch 'dev' into wip/dk/proof-refactoring

    # Conflicts:
    #	trunk/source/InvariantSynthesis/src/de/uni_freiburg/informatik/ultimate/plugins/generator/invariantsynthesis/InvariantSynthesisStarter.java
    #	trunk/source/Library-ModelCheckerUtils/src/de/uni_freiburg/informatik/ultimate/lib/modelcheckerutils/smt/predicates/PredicateUtils.java
    #	trunk/source/TraceAbstraction/src/de/uni_freiburg/informatik/ultimate/plugins/generator/traceabstraction/TraceAbstractionStarter.java
    maul-esel committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    65dc64b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    00854ba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    be8f228 View commit details
    Browse the repository at this point in the history
  4. fix copyright

    maul-esel committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    bbace90 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    05361c4 View commit details
    Browse the repository at this point in the history
  6. cleanup and comments

    maul-esel committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    c6c3409 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6ac7e5e View commit details
    Browse the repository at this point in the history
  8. continue refactoring; major simplifications

    - introduce marker interface IProof to avoid using Object
    - decouple AbstractCegarLoop, CegarLoopResult from proof production
    - remove useless interfaces
    - decouple proofs and proof translation from IInitialAbstractionProvider interface
    maul-esel committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    be80620 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Configuration menu
    Copy the full SHA
    1083d51 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    766c9b2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7c30132 View commit details
    Browse the repository at this point in the history
  4. fix NPEs

    maul-esel committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e56112c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    260f8f7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    42e75cd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c866311 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c42ea25 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4355d7b View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Configuration menu
    Copy the full SHA
    f5d630e View commit details
    Browse the repository at this point in the history
  2. contract computation: requires may be needed even if ensures is null …

    …to prove asserts inside the procedure
    maul-esel committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    9ddd293 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. fix NPEs

    maul-esel committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    a77894b View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Configuration menu
    Copy the full SHA
    ccca8fe View commit details
    Browse the repository at this point in the history
  2. minor cleanup

    maul-esel committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    1e57a53 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge branch 'dev' into wip/dk/proof-refactoring

    Removes the workaround introduced in 720a012, as proofs of different
    CEGAR loops are now stored separately in the ICFG.
    
    # Conflicts:
    #	trunk/source/TraceAbstraction/src/de/uni_freiburg/informatik/ultimate/plugins/generator/traceabstraction/NwaCegarLoop.java
    maul-esel committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    122fb1c View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Configuration menu
    Copy the full SHA
    2b4fdb3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    053cbaa View commit details
    Browse the repository at this point in the history
  3. add explicit representations of the specification shown by a proof

    This is particularly useful if we create multiple proof objects
    for the same program and different (partial) specifications, to
    distinguish which proof objects relate to which specification.
    maul-esel committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    9007b66 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Configuration menu
    Copy the full SHA
    a2c4c3b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    591e8a7 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. fix block encoding bug discovered by contract computation

    Every procedure that exists in the IIcfg should have an exit location,
    even if that location is unreachable.
    
    This was not the case for the IIcfgs produced by the BlockEncodingV2 plugin.
    This commit fixes this bug, and introduces an assert statement after block
    encoding has finished to check if the produced IIcfg satisfies this invariant.
    
    Moreover, we add two sanity checks regarding the computation of procedure contracts,
    where the problem was discovered (the location of the ProcedureContractResult was null),
    such that similar issues are caught earlier in the future.
    maul-esel committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    32bd4b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Merge branch 'dev' into wip/dk/proof-refactoring

    # Conflicts:
    #	trunk/source/InvariantSynthesis/src/de/uni_freiburg/informatik/ultimate/plugins/generator/invariantsynthesis/InvariantSynthesisStarter.java
    #	trunk/source/Library-ModelCheckerUtils/src/de/uni_freiburg/informatik/ultimate/lib/modelcheckerutils/smt/predicates/HoareAnnotation.java
    #	trunk/source/Library-ModelCheckerUtils/src/de/uni_freiburg/informatik/ultimate/lib/modelcheckerutils/smt/predicates/PredicateFactory.java
    #	trunk/source/TraceAbstraction/src/de/uni_freiburg/informatik/ultimate/plugins/generator/traceabstraction/HoareAnnotationWriter.java
    maul-esel committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    9d7a9aa View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Configuration menu
    Copy the full SHA
    6679c7b View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. more documentation

    maul-esel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    044eca1 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'dev' into wip/dk/proof-refactoring

    # Conflicts:
    #	releaseScripts/website-config/frontend/config.js
    #	trunk/source/WebsiteStatic/config/config.dist.js
    maul-esel committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    b03ad22 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5f48c28 View commit details
    Browse the repository at this point in the history