Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTD-5769: Add option to approve multiple cases #2294

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

saruniitr
Copy link
Contributor

@saruniitr saruniitr commented Jan 10, 2025

Change description

Add button on cases queue view to approve multiple cases.
This is enabled selectively on specific teams queues and there is a rule to enforce this.

A new endpoint is added for this purpose and the relevant PR is uktrade/lite-api#2362

This is initially allowed to only certain team's queues so add a rule
to enforce the same.
Success message not being displayed with templateview for some reason.
It could possibly be because of the messages middleware as we handle
post ourselves.
"""
Submit approval recommendation for the selected cases
"""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To protect the view I think we need to test user permission here also similar to

if not rules.test_rule("can_licence_status_be_changed", self.request, self.licence):

Copy link
Contributor

@depsiatwal depsiatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also assume can't be merged until API has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants