Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ltd 5714 other ogd sessionwizard #2263

Merged
merged 20 commits into from
Jan 14, 2025
Merged

Ltd 5714 other ogd sessionwizard #2263

merged 20 commits into from
Jan 14, 2025

Conversation

Tllew
Copy link
Contributor

@Tllew Tllew commented Dec 5, 2024 •
edited
Loading

replaced is_desnz with is_ogd team to ensure fcdo can't access the site manually
only sending to legacy view when fcdo team

  • Added a constant to WebDriverDelay due to frustration, leaving it in so we have a set place to modify this delay incase someone else gets as frustrated as I did with the tests

LTD-5714

@Tllew Tllew force-pushed the LTD-5706-approve-session-wizard branch 2 times, most recently from 3abfcc1 to fec9881 Compare December 9, 2024 12:16
@Tllew Tllew force-pushed the LTD-5714-other-ogd-sessionwizard branch from 38f2d86 to b493985 Compare December 9, 2024 15:30
Base automatically changed from LTD-5706-approve-session-wizard to dev December 10, 2024 09:40
@Tllew Tllew force-pushed the LTD-5714-other-ogd-sessionwizard branch 5 times, most recently from a0a4030 to 80c4dcc Compare December 12, 2024 13:47
@Tllew Tllew marked this pull request as ready for review December 12, 2024 14:01
currycoder
currycoder reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@currycoder currycoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions throughout to clean this up a bit. Otherwise looking great

caseworker/advice/forms/approval.py Show resolved Hide resolved
caseworker/advice/templates/advice/view_my_advice.html Show resolved Hide resolved
caseworker/advice/views/approval.py Outdated Show resolved Hide resolved
caseworker/advice/views/approval.py Outdated Show resolved Hide resolved
kevincarrogan
kevincarrogan reviewed Dec 27, 2024
View reviewed changes
caseworker/advice/conditionals.py Outdated Show resolved Hide resolved
caseworker/advice/forms/approval.py Show resolved Hide resolved
caseworker/advice/rules.py Outdated Show resolved Hide resolved
tests_common/constants.py Outdated Show resolved Hide resolved
@Tllew Tllew force-pushed the LTD-5714-other-ogd-sessionwizard branch from 083c5c4 to 775b745 Compare January 6, 2025 09:58
@Tllew Tllew force-pushed the LTD-5714-other-ogd-sessionwizard branch 3 times, most recently from 530e2e8 to 3ce28d4 Compare January 13, 2025 09:12
Tllew and others added 3 commits January 13, 2025 09:14
@Tllew
fix e2e
5868c36
@currycoder @Tllew
Ensure checkbox licence conditions collapse to single textbox when th…
3156492 
…ere are no picklist conditions
@Tllew
Remove unecessary margin styling
5053276 
updating to reflect simple form

actually saving

fix e2e
@Tllew Tllew force-pushed the LTD-5714-other-ogd-sessionwizard branch from 3ce28d4 to 5053276 Compare January 13, 2025 09:20
@Tllew Tllew merged commit 2d201ca into dev Jan 14, 2025
12 checks passed
@Tllew Tllew deleted the LTD-5714-other-ogd-sessionwizard branch January 14, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saruniitr saruniitr saruniitr left review comments

@currycoder currycoder currycoder approved these changes

@kevincarrogan kevincarrogan kevincarrogan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tllew @kevincarrogan @saruniitr @currycoder