Ltd 5653 desnz multiple licence conditions #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tllew
force-pushed
the
LTD_5653_DESNZ_multiple_licence_conditions
branch
from
6e48010 to
26dafad
Compare
currycoder
reviewed
Nov 25, 2024
Tllew
force-pushed
the
LTD_5653_DESNZ_multiple_licence_conditions
branch
2 times, most recently
from
422a817 to
185de88
Compare
currycoder
approved these changes
Nov 25, 2024
caseworker/advice/forms.py
Outdated
|
|
||
| def __init__(self, *args, **kwargs): | ||
| kwargs.pop("approval_reason") | ||
| kwargs.pop("proviso") |
There was a problem hiding this comment.
Still wondering about this
| "footnote": data["footnote_details"], | ||
| "proviso": data.get("proviso", ""), | ||
| "note": data.get("instructions_to_exporter", ""), | ||
| "footnote_required": True if data.get("footnote_details") else False, |
There was a problem hiding this comment.
I meant the field in general - footnote and footnote_required seems odd
Tllew
force-pushed
the
LTD_5653_DESNZ_multiple_licence_conditions
branch
2 times, most recently
from
d3dc88e to
6ed6bd7
Compare
currycoder
reviewed
Nov 29, 2024
currycoder
force-pushed
the
LTD_5653_DESNZ_multiple_licence_conditions
branch
from
5bead11 to
8c6fede
Compare
caseworker/advice/forms.py
Outdated
|
|
||
| def __init__(self, *args, **kwargs): | ||
| kwargs.pop("approval_reason") | ||
| kwargs.pop("proviso") |
There was a problem hiding this comment.
I'm seeing this in all of the forms and it makes me wonder if there's a better way of solving this than just popping things to make them go away.
I also prefer del in cases where we are not using the returned value.
unit_tests/caseworker/advice/views/test_give_approval_advice_view.py
Outdated
Show resolved
Hide resolved
Tllew
force-pushed
the
LTD_5653_DESNZ_multiple_licence_conditions
branch
from
d5d5833 to
94b6d62
Compare
…e other forms too
…ion everywhere soon
…d a backlink and moved some logic to rules
Tllew
force-pushed
the
LTD_5653_DESNZ_multiple_licence_conditions
branch
from
94b6d62 to
915e82e
Compare
kevincarrogan
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted GiveApprovalAdviceView to a sessionwizard
Added conditional checkboxes to the licence conditions
Added a DESNZeditview to handle the prepopulation of the sessionwizard
Renamed the old views to be -legacy to move us a step closer toward this flow being the default (because of this it may be difficult to read the file changes, I'd recommend checking the commit history for a simpler view of the changes)
This is hopefully the first step to converting this whole are to a sessionwizard and removing the factories
LTD-5653