LTD-5702: Update goods endpoint tests #2327
Open
+98
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | id | 03fb08eb-1564-4b68-9336-3ca8906543f9 | | ||
| When the application is submitted | ||
| And the application is issued at 2024-11-22T13:35:15 | ||
| Then the `destinations` table has the following rows: |
There was a problem hiding this comment.
I feel this test isn’t really telling a reader anything about how these values are getting set, they just sort of seem to appear from nowhere.
There was a problem hiding this comment.
ok, I was only trying to update the format, will improve the test.
| | good_on_application_id | 94590c78-d0a9-406d-8fd3-b913bf5867a9 | | ||
| When the application is submitted | ||
| Then the `goods` table has the following rows: | ||
| | id | application_id | quantity | unit | value | |
There was a problem hiding this comment.
This test feels the same as the one above where it’s not really describing how these values happen to be the values that end up in the table they just sort of exist for no apparent reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim
LTD-