Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small modification in notebooks #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

afoix
Copy link

@afoix afoix commented Nov 24, 2023

Modification in notebook 1

  • Add some python idioms
  • Change the name of ordered() function to sorted_by_distance()
  • Add comments and description in the skeletonise and sorted_by_distance() functions

Modification in notebook 2A

  • There is a typo in 2.6 that makes the don’t run. It’s an extra ] that I’ve remove it.
  • Add comments in 0.1 in the code block of the number of points. Explanation about the dimensions.
  • First code block of 1.3 add explanation about imaginary numbers and its format (Cartesian form)
  • 1.4 second block, explanation of the exponential form of the imaginary.
  • In the regular notebook 2A in the first code block of 3.2 there his a dtype=np.complex, this does not work, it need to be dtype=complex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant