minor fixes

uhh-cms · Jan 7, 2025 · 1172404 · 1172404
1 parent 4eb31b7
commit 1172404
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/hbw/ml/base.py b/hbw/ml/base.py
@@ -110,6 +110,7 @@ def __init__(
 
         for param in self.settings_parameters:
             # overwrite the default value with the value from the parameters
+            # TODO: this is quite dangerous, as it overwrites a class attribute instead of an instance attribute
             setattr(self, param, self.parameters.get(param, getattr(self, param)))
 
         # cast the ml parameters to the correct types if necessary

diff --git a/hbw/production/neutrino.py b/hbw/production/neutrino.py
@@ -167,7 +167,7 @@ def top_reconstruction(self: Producer, events: ak.Array, **kwargs) -> ak.Array:
         # replace nan, none, and inf values with EMPTY_FLOAT
         col = route.apply(events)
         col = ak.fill_none(ak.nan_to_none(route.apply(events)), EMPTY_FLOAT)
-        col = ak.where(np.isinf(col), EMPTY_FLOAT, col)
+        col = ak.where(~np.isfinite(col), EMPTY_FLOAT, col)
 
         events = set_ak_column(events, route.string_column, col)
 

diff --git a/hbw/selection/dl_remastered.py b/hbw/selection/dl_remastered.py
@@ -106,7 +106,12 @@ def dl_lepton_selection(
 
     dilepton = ak.pad_none(lepton, 2)
     dilepton = dilepton[:, 0] + dilepton[:, 1]
-    events = set_ak_column(events, "mll", ak.fill_none(dilepton.mass, EMPTY_FLOAT), value_type=np.float32)
+    events = set_ak_column(
+        events,
+        "mll",
+        ak.fill_none(ak.nan_to_none(dilepton.mass), EMPTY_FLOAT),
+        value_type=np.float32,
+    )
     lepton_results.steps["DiLeptonMass81"] = ak.fill_none(dilepton.mass <= m_z.nominal - 10, False)
     # lepton channel masks
     lepton_results.steps["Lep_mm"] = mm_mask = (