Run3 process updates #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mafrahm
commented
Jan 12, 2024
mafrahm
commented
- updates the 13 TeV ttbar cross section
- adds some 13.6 TeV cross sections (Higgs + ttbar)
- some configuration changes for hh2bbww processes
|
Is this ready for review @mafrahm ? |
nprouvost
requested changes
Feb 14, 2024
There was a problem hiding this comment.
General comments:
- Add revision/version number for the links
- Add comments on which higgs mass is used for the cross sections of the higgs samples
- I would recommend to use the values for mH=125 GeV such that such a value exists for each process (e.g. 125.09 is not given for the di-higgs processes) and because most MC samples are produced for a Higgs mass value for 125GeV, changing the shape of the the distribution. An other possibility would be to verify for each sample which Higgs mass value was used for the sample production and get the cross sections for this value. However, this might be disadvantageous if some samples have different Higgs mass value over the different years.
nprouvost
requested changes
Feb 14, 2024
aalvesan
requested changes
Feb 15, 2024
Co-authored-by: Ana Andrade <[email protected]>
|
@nprouvost @aalvesan Did the above commits resolve your review comments? |
aalvesan
approved these changes
Apr 24, 2024
nprouvost
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.