Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition from Field Injection to Constructor Injection #953

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Transition from Field Injection to Constructor Injection #953

merged 1 commit into from
Jul 18, 2024

Conversation

hokwaichan
Copy link
Contributor

@hokwaichan hokwaichan commented Jul 9, 2024 •
edited
Loading

Ticket Link

1719

List of squashed commits

  • Transition from Field Injection to Constructor Injection

Test Checklist

  • Exhibits Clear Code Structure:
  • Project Unit Tests Passed:
  • Project Jasmine Tests Passed:
  • Executes Expected Functionality:
  • Tested For Incorrect/Unexpected Inputs:

@mhodgesatuh mhodgesatuh requested review from fduckart and removed request for mhodgesatuh July 9, 2024 18:49
@hokwaichan hokwaichan force-pushed the dev-hokwai-1719 branch 2 times, most recently from 0b8bf3b to 2b73f24 Compare July 10, 2024 02:36
JorWo
JorWo approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@JorWo JorWo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just waiting on your API PR now.

@JorWo JorWo merged commit 564c8d4 into uhawaii-system-its-ti-iam:main Jul 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fduckart fduckart fduckart left review comments

@JorWo JorWo JorWo approved these changes

@gitCarrot gitCarrot Awaiting requested review from gitCarrot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hokwaichan @fduckart @JorWo