Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and fix the possible issue from spring boot devtools maven dependency #1045

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

gitCarrot
Copy link
Contributor

@gitCarrot gitCarrot commented Nov 5, 2024

Ticket Link

Ticket-1850

List of squashed commits

  • Investigate and fix the possible issue from spring boot devtools maven dependency
  • Make configuration class for hot reload on localhost without setting absolute project directory path in application.properties
  • Implement the test checking the config class for hot reload
  • Fix codacy code style

Test Checklist

  • Exhibits Clear Code Structure:
  • Project Unit Tests Passed:
  • Project Jasmine Tests Passed:
  • Executes Expected Functionality:
  • Tested For Incorrect/Unexpected Inputs:

@JorWo
Copy link
Contributor

JorWo commented Nov 7, 2024

We should keep this dependency because live reload is nice to have for Angular.js.

@gitCarrot
Copy link
Contributor Author

Are we actually using live reload now in angular js? Without adding some devtools properties, it seems live reload is not working on current configuration

@JorWo
Copy link
Contributor

JorWo commented Nov 7, 2024

Yeah we have used it in the past but it seems that it has broke after updating the Spring Boot version. I remember the live reload with Angular.js only works with .js files and not .html. Could you investigate further? Thanks.

@JorWo JorWo merged commit d073af0 into uhawaii-system-its-ti-iam:main Dec 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants