Skip to content

Commit

Permalink
Fix success modal for reset grouping (#807)
Browse files Browse the repository at this point in the history
Add debug message to catches

Fix codacy

Remove $log messages
  • Loading branch information
yertsti authored May 20, 2023
1 parent 42efe7d commit 434ef57
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
15 changes: 10 additions & 5 deletions src/main/resources/static/javascript/mainApp/general.controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
$scope.invalidMembers = [];
$scope.membersInList = "";
$scope.isMultiAdd = false;

// Remove members
$scope.multiRemoveResults = [];
$scope.membersToRemove = [];
Expand Down Expand Up @@ -913,7 +912,7 @@
$scope.getGroupingInformation();
$scope.syncDestArray = [];
}
});
}).catch(() => {});
}

/**
Expand Down Expand Up @@ -1328,7 +1327,7 @@
$scope.loading = true;
clearMemberInput($scope.listName);
$scope.getGroupingInformation();
});
}).catch(() => {});
}

/**
Expand Down Expand Up @@ -1524,6 +1523,7 @@
}
}
}

// Otherwise, display the result success modal.
$scope.displaySuccessfulGroupResetModal((() => {
if (results.includeSuccess && results.excludeSuccess) {
Expand Down Expand Up @@ -1553,9 +1553,14 @@
$scope.successfulGroupResetModalInstance = $uibModal.open({
templateUrl: "modal/successfulGroupResetModal",
scope: $scope,
backdrop: "static",
keyboard: false
backdrop: true,
keyboard: true
});

$scope.successfulGroupResetModalInstance.result.finally(() => {
$scope.loading = true;
$scope.getGroupingInformation();
}).catch(() => {});
};

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<html xmlns:th="http://www.thymeleaf.org" lang="en">
<div class="modal-header">
<h5 class="modal-title" id="modal-title">Grouping Reset Completion</h5>
<a class="close" type="button" ng-click="closeResetNotifModal()">
<a class="close" type="button" ng-click="closeSuccessfulGroupResetModal()">
<span aria-hidden="true">&times;</span>
</a>
</div>
Expand Down

0 comments on commit 434ef57

Please sign in to comment.