Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed restart non-reproducing issue 2588 when using MERRA2 climatology + Add output of ocean scalar variables for quick diagnostics #2632 + Fix CICD Jenkinsfile change default RT suite to full #2628 #2625

Merged
merged 31 commits into from
Mar 10, 2025

Conversation

AnningCheng-NOAA
Copy link
Contributor

@AnningCheng-NOAA AnningCheng-NOAA commented Feb 27, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Commit Message:

* UFSWM - Add output of diagnostic ocean scalar variables: diag_table_cpld_sfs.IN
* UFSWM - Jenkinsfile update
  * FV3 - 
    * ccpp-physics -  a few of lines of code modified in aerinterp.F90

Priority:

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@DeniseWorthen
Copy link
Collaborator

@AnningCheng-NOAA Thanks for the fix! I've confirmed also that your fix passes the restart tests at day 15, hour 00 in my reproducer branch.

@DeniseWorthen
Copy link
Collaborator

@jkbk2004 This is a critical bug fix.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 3, 2025

@jkbk2004 This is a critical bug fix.

Sure! If possible, I like to schedule today with some other no baseline change PRs.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 4, 2025

@AnningCheng-NOAA can you sync up branches?

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented Mar 4, 2025 via email

@jkbk2004 jkbk2004 changed the title fixed restart non-reproducing issue 2588 when using MERRA2 climatology fixed restart non-reproducing issue 2588 when using MERRA2 climatology + Add output of ocean scalar variables for quick diagnostics #2632 Mar 5, 2025
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 5, 2025

@sanAkel I combined #2632 to this pr.

@sanAkel
Copy link
Contributor

sanAkel commented Mar 5, 2025

@sanAkel I combined #2632 to this pr.

Thanks @jkbk2004

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Mar 6, 2025

@AnningCheng-NOAA can you sync up branches one more time? We can start working on this pr.

@DeniseWorthen
Copy link
Collaborator

@jkbk2004 Please be sure to commit a clean test change list for this PR. I see you posted the log, but Anning's branch still shows the previous list I believe.

@jkbk2004 jkbk2004 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Mar 7, 2025
@jkbk2004 jkbk2004 removed the jenkins-ort run ORT testing label Mar 10, 2025
@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA skip acorn for this pr?

@BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA skip acorn for this pr?

Nope, Acorn almost finished.

@jkbk2004
Copy link
Collaborator

OK! we can start merging.

@jkbk2004 jkbk2004 merged commit 9dc31e4 into ufs-community:develop Mar 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failure to restart-reproduce if using a restart from 15th of month
8 participants