-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strongly typed extension storage #6114
Draft
arnaugomez
wants to merge
2
commits into
ueberdosis:develop
Choose a base branch
from
arnaugomez:feature/strongly-typed-extension-storage
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Strongly typed extension storage #6114
arnaugomez
wants to merge
2
commits into
ueberdosis:develop
from
arnaugomez:feature/strongly-typed-extension-storage
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ff8d99a The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for tiptap-embed failed. Why did it fail? →
|
I see the Netlify preview failed as the types have broken 🙈 , will check and fix it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Allow the type of the extensionStorage field of the Editor class to be customizable.
Usage (Example with characterCount extension)
Implementation Approach
Create a new
ExtionsionStorage
interface in@tiptap/core
. This type works very similar to theCommands
interface: it can be extended and customized inside the extension code.Testing Done
The runtime code has not been changed. Only the types.
Verification Steps
Check the types of the
Editor.extensionStorage
field.Additional Notes
This feature is a proposal and it is still under discussion so the maintainers might decide that it is not necessary. Tell me if you like it/hate it, feedback is welcome.
The type of the
Editor.extensionStorage
field is set toExtensionStorage | Record<string, any>
instead ofExtensionStorage
so that it accounts for extensions where the types have not been set.Checklist
Related Issues
Discussion