Add shouldShow callback to bubble menu #1710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that’s a great PR! @philippkuehn What do you think? @georgeboot Any chance you could add a usage example to the docs? |
|
@hanspagel I've made a few tweaks and added a real usage example to the docs |
|
Hey, thanks for that but this is a really bad timing because I’ve done this in a separate branch yesterday 😬 |
|
@philippkuehn Oh! Can you make sure to also keep a usage example in the docs? |
|
Jep, on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1480
Relates to #1313 (see #1313 (comment))
This PR adds a
shouldOpencallback for the bubble menu. This allows users to control whether the bubbleMenu should open or not. By default, the new callback will always returntrueso there isn't an issue with bc.