Remove Strict Versioning on scrivo/highlight.php #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @digidux! Your code changes does also contain a strict version. That is also the recommend way noted in the readme, which you have linked to. So please can you enhance your pull request by changing the version again? |
|
Hi @oqq! I've just updated it. Thanks! :) |
|
@digidux thanks a lot. Unfortunately, i am not a maintainer of this library. That's why we still have to wait for an approval. 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue mentioned in #41.
Removing the strict version lock allow for more compatibility. And to follow the guidelines set by the authors themselves. scrivo/highlight.php's readme.md.