Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/arbol contable refactor #134

Merged
merged 8 commits into from
Jan 3, 2022
Merged

Feature/arbol contable refactor #134

merged 8 commits into from
Jan 3, 2022

Conversation

salcedogeiner
Copy link
Contributor

@salcedogeiner salcedogeiner commented Jan 2, 2022 •
edited
Loading

AlexFBP
AlexFBP suggested changes Jan 2, 2022
View reviewed changes
Copy link
Contributor

@AlexFBP AlexFBP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En general, bien. Si bien se dejaron varios comentarios, la mayoría quedaron como suggested changes que se pueden seleccionar y aplicar desde la interfaz web. La mayoría son respecto a evitar código comentado

src/app/@theme/components/reactive-form/reactive-control/reactive-control.component.scss Outdated Show resolved Hide resolved
src/app/@theme/components/reactive-form/reactive-control/reactive-control.component.ts Outdated Show resolved Hide resolved
src/app/@theme/components/reactive-form/reactive-control/reactive-control.component.ts Outdated Show resolved Hide resolved
src/app/@theme/components/reactive-form/reactive-control/reactive-control.component.ts Outdated Show resolved Hide resolved
src/app/@theme/components/reactive-form/reactive-control/reactive-control.component.ts Outdated Show resolved Hide resolved
src/app/pages/arbol-cuentas-contables/cuenta-contable/cuenta-contable.component.html Outdated Show resolved Hide resolved
src/app/pages/arbol-cuentas-contables/cuenta-contable/cuenta-contable.component.ts Outdated Show resolved Hide resolved
src/app/pages/arbol-cuentas-contables/selector-contable/selector-contable.component.html
</button>
</nb-card-footer>

</nb-card>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</nb-card>
</nb-card>

src/app/pages/arbol-cuentas-contables/selector-contable/selector-contable.component.ts Outdated Show resolved Hide resolved
src/app/pages/arbol-cuentas-contables/selector-contable/selector-contable.component.ts Outdated Show resolved Hide resolved
@AlexFBP AlexFBP self-assigned this Jan 3, 2022
AlexFBP
AlexFBP approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@AlexFBP AlexFBP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprobado con comentarios pendientes

@AlexFBP AlexFBP merged commit e27682d into develop Jan 3, 2022
@AlexFBP AlexFBP deleted the feature/arbol-contable-refactor branch January 3, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexFBP AlexFBP AlexFBP approved these changes

Assignees

@AlexFBP AlexFBP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salcedogeiner @AlexFBP