Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: bc1f0e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7403c750ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// <reference types="next/image-types/global" /> | ||
| /// <reference types="next/navigation-types/compat/navigation" /> | ||
| import "./.next/types/routes.d.ts"; | ||
| import "./.next/dev/types/routes.d.ts"; |
There was a problem hiding this comment.
Keep next-env route import stable across dev/build modes
This import was changed to ./.next/dev/types/routes.d.ts, which is a dev-mode output path. In build/typegen flows Next writes route types under ./.next/types/routes.d.ts, so this committed value becomes mode-dependent and gets rewritten in non-dev workflows, creating deterministic churn and potentially pointing at a missing route-types file when only build artifacts are present.
Useful? React with 👍 / 👎.
Fixes #4956
What
mousedownguard for unmapped editor-root clicks.data-slate-node=\"value\"as the editor root, not a mapped Slate descendant.apps/www/next-env.d.tsroute-type path change.Verification
bun test packages/table/src/react/onMouseDownTable.spec.tsxfailed before the root guard handleddata-slate-node=\"value\".pnpm installpnpm turbo build --filter=./packages/tablepnpm turbo typecheck --filter=./packages/tablebun test packages/table/srcpnpm lint:fixpnpm check/docs/table, root click target wasdata-slate-node=\"value\", selection moved to Slate text, typed text stayed in the table, and no console/page errors fired.Browser Proof
Screenshot captured locally at
/Users/zbeyens/.dev-browser/tmp/plate-4956-table-unmapped-click-fixed.png.