Made error causing gdisconnect behave like fbconnect.#54
Open
acmujica wants to merge 1 commit intoudacity:masterfrom
acmujica:master
Open
Made error causing gdisconnect behave like fbconnect.#54acmujica wants to merge 1 commit intoudacity:masterfrom acmujica:master
acmujica wants to merge 1 commit intoudacity:masterfrom
acmujica:master
Conversation
Gdisconnect originally was responsible for deleting all the login_session attributes. However in this lesson we refactored that ability to a more general disconnect function. Therefore gdisconnect should behave the same way as fbconnect.
Author
|
Fbconnect should be Chris connect sorry for any confusion |
Author
|
Fbconnect should be fbdisconnect sorry for any confusion and also auto correct. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gdisconnect originally was responsible for deleting all the login_session attributes. However in this lesson we refactored that ability to a more general disconnect function. Therefore gdisconnect should behave the same way as fbconnect. In the current form the attributes are attempted to be deleted twice and causes the program to enter debug mode.