Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] pgx v5 #25

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
fix: Remove unused params
cjfinnell committed Oct 24, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 6255e5d692a4cc3fd6e37e8c98fb05c56f8bc507
4 changes: 2 additions & 2 deletions verify.go
Original file line number Diff line number Diff line change
@@ -87,7 +87,7 @@ func (c Config) Verify(ctx context.Context, targets []*pgx.ConnConfig) (*Results
func (c Config) runTestsOnTarget(ctx context.Context, targetName string, conn *pgx.Conn, finalResults *Results, done chan struct{}) {
logger := c.Logger.WithField("target", targetName)

schemaTableHashes, err := c.fetchTargetTableNames(ctx, logger, conn)
schemaTableHashes, err := c.fetchTargetTableNames(ctx, conn)
if err != nil {
logger.WithError(err).Error("failed to fetch target tables")
close(done)
@@ -108,7 +108,7 @@ func (c Config) runTestsOnTarget(ctx context.Context, targetName string, conn *p
close(done)
}

func (c Config) fetchTargetTableNames(ctx context.Context, logger *logrus.Entry, conn *pgx.Conn) (SingleResult, error) {
func (c Config) fetchTargetTableNames(ctx context.Context, conn *pgx.Conn) (SingleResult, error) {
schemaTableHashes := make(SingleResult)

rows, err := conn.Query(ctx, buildGetTablesQuery(c.IncludeSchemas, c.ExcludeSchemas, c.IncludeTables, c.ExcludeTables))