Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change json dependency to use org.json #123

Open
wants to merge 6 commits into
base: nimak/add-werror
Choose a base branch
from

Conversation

nimakarimipour
Copy link
Member

@nimakarimipour nimakarimipour commented Jan 2, 2023

This is a followup PR for #107 which removes some added @SuppressWarnings. Current json dependency results to a unchecked warning reported by Javac in every JSONObject construction. The only way to remove these warnings is to either silence them by @SuppressWarnings (current state) or use a different and more recent json library. This PR removes inserted @SuppressWarnings and updates json dependency to use a newer library org.json.

@nimakarimipour nimakarimipour added the refactoring/simplification Refactoring Simplification label Jan 2, 2023
@nimakarimipour nimakarimipour self-assigned this Jan 2, 2023
@nimakarimipour nimakarimipour added the low priority Low priority task label Feb 17, 2023
@nimakarimipour nimakarimipour changed the base branch from master to nimak/add-werror March 12, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Low priority task refactoring/simplification Refactoring Simplification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant