Change regex definitions to use raw strings #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lint throwing `SyntaxError` due to invalid escape sequences like `'\.'` which should either be written as `'\\.'` or `r'\.'` instead. Please refer to https://docs.python.org/3/howto/regex.html for further details.
jonasbardino
force-pushed
the
adjust/shared-defaults-regexes-to-use-raw-strings-to-avoid-syntaxerror
branch
from
cb1ce0a to
70e9eb5
Compare
jonasbardino
deleted the
adjust/shared-defaults-regexes-to-use-raw-strings-to-avoid-syntaxerror
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change regex definitions to use raw strings in order to avoid e.g. pylint throwing
SyntaxErrordue to invalid escape sequences like'\.'which should either be written as'\\.'orr'\.'instead.Please refer to https://docs.python.org/3/howto/regex.html for further details.
We already have implicit unit tests to cover this change as the regex raw strings are used e.g. in the
migerrorscronjob, which is automatically generated and checked against the constant fixture version intests/test_mig_shared_install.py.