Repository navigation
compiler: account for nested imports in the importer's export offset - #487
Merged
Merged
Conversation
When a module is linked in at compile time, the importing source's export offset was advanced by the linked module's own export count only. Modules that the linked module itself imported also allocate slots in the shared export table before the importer's own exports, but were not counted. For the root of a runtime `import()` this yielded a too small offset once the import graph was more than one level deep, so `uc_require_imports()` paired exported names with the values of unrelated, nested modules (e.g. an exported function resolving to a function of a transitively imported module). Advance the importer's offset by the number of export slots actually allocated while compiling the import, which covers the linked module and all modules it pulled in transitively. Add a regression test with a three level import chain. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compiler: account for nested imports in the importer's export offset
When a module is linked in at compile time, the importing source's export
offset was advanced by the linked module's own export count only. Modules
that the linked module itself imported also allocate slots in the shared
export table before the importer's own exports, but were not counted.
For the root of a runtime
import()this yielded a too small offset oncethe import graph was more than one level deep, so
uc_require_imports()paired exported names with the values of unrelated, nested modules (e.g. an
exported function resolving to a function of a transitively imported
module).
Advance the importer's offset by the number of export slots actually
allocated while compiling the import, which covers the linked module and
all modules it pulled in transitively.
Add a regression test with a three level import chain.
Signed-off-by: Jo-Philipp Wich jo@mein.io