MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ranch-test-header-links
…ranch-test-cons-record-creation
Janell-Huyck
changed the title
Janell-Huyck
changed the title
…ranch-test-cons-record-creation
crowesn
approved these changes
Apr 30, 2024
crowesn
merged commit dcd2f3e
into
214-feature-branch-refactor-feature-testing
1 check failed
Janell-Huyck
added a commit
that referenced
this pull request
May 1, 2024
…GE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution
crowesn
pushed a commit
that referenced
this pull request
May 2, 2024
…#487) * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests
crowesn
pushed a commit
that referenced
this pull request
May 2, 2024
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix broken test
crowesn
pushed a commit
that referenced
this pull request
May 3, 2024
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests
crowesn
pushed a commit
that referenced
this pull request
May 3, 2024
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * Fix failing test
crowesn
pushed a commit
that referenced
this pull request
May 3, 2024
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * WIP - Edit User Specs * Fix broken tests
crowesn
pushed a commit
that referenced
this pull request
May 3, 2024
…IRST (#492) * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * WIP - Edit User Specs * Fix broken tests * Migrate controlled vocab creation specs * Correct spelling name of test
Janell-Huyck
added a commit
that referenced
this pull request
May 28, 2024
…GE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution
Janell-Huyck
added a commit
that referenced
this pull request
May 28, 2024
…#487) * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests
Janell-Huyck
added a commit
that referenced
this pull request
May 28, 2024
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix broken test
Janell-Huyck
added a commit
that referenced
this pull request
May 28, 2024
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests
Janell-Huyck
added a commit
that referenced
this pull request
May 28, 2024
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * Fix failing test
Janell-Huyck
added a commit
that referenced
this pull request
May 28, 2024
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * WIP - Edit User Specs * Fix broken tests
Janell-Huyck
added a commit
that referenced
this pull request
May 28, 2024
…IRST (#492) * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * WIP - Edit User Specs * Fix broken tests * Migrate controlled vocab creation specs * Correct spelling name of test
Janell-Huyck
added a commit
that referenced
this pull request
Jul 2, 2024
…GE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution
Janell-Huyck
added a commit
that referenced
this pull request
Jul 2, 2024
…#487) * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests
Janell-Huyck
added a commit
that referenced
this pull request
Jul 2, 2024
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix broken test
Janell-Huyck
added a commit
that referenced
this pull request
Jul 2, 2024
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests
Janell-Huyck
added a commit
that referenced
this pull request
Jul 2, 2024
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * Fix failing test
Janell-Huyck
added a commit
that referenced
this pull request
Jul 2, 2024
* Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * WIP - Edit User Specs * Fix broken tests
Janell-Huyck
added a commit
that referenced
this pull request
Jul 2, 2024
…IRST (#492) * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * MERGE TO FEATURE BRANCH - 214 - Test viewing pages - MERGE FIRST (#475) * Lay out proposed file structure for tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Use shared examples and context for page viewing * Rubocop & add Capybara wait time * MERGE TO FEATURE BRANCH - 214 - Test Header and Search - MERGE FIRST (#481) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * MERGE TO FEATURE BRANCH - 214 Test Conservation Record Creation - MERGE FIRST (#485) * Lay out proposed file structure for tests * Update rails_helper.rb and fix broken tests * Merge conflicts * Rebase merge conflict * Log in use specs with context * Rubocop: * Rubocop * Use shared examples and context for page viewing * Check headers and search functionality * Lay out proposed file structure for tests * Merge conflict resolved * Merge conflicts * Rebase merge conflict * Rubocop: * Test conservation_record creation in feature tests * Fix accidental rubocop error created by manual merge conflict resolution * Rubocop fix * Move editing cons record to shared example * Correct cons record factory * Rubocop fix * Fix some broken tests * Rubocop fix * Add seeding to the circleci testing: * Update tests * Test adding new staff codes * Remove duplicated code related to creating new staff codes * Correct failing test * Fix more broken tests * Test creating a new user * WIP - Edit User Specs * Fix broken tests * Migrate controlled vocab creation specs * Correct spelling name of test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #214
This PR tests the ability of users to create new conservation records. Anonymous and read-only users are unable to access this page, and we check that the read-only user does not have any links to create a new record.
We add in a new check for unauthorized access that checks for disabled buttons for the specified link. If a button to that link is present, it must be disabled.
We increase testing specification for flash messages with two new helper methods:
flash_noticeandflash_alert, specifying that the flash text should be within a flash message and either be a standard notice or a warning alert. This presumes the use of bootstrap, which we are using to manage flash messages.We created a shared example
creates new conservation recordsthat is called on by both the admin and the standard user, who should each be able to create new conservation records.Code that checked that the users could create new conservation records has been removed from the old tests.