Update Ruby to 3.2.2 for everything and Rails to 6.1.7.6 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is an additional Coveralls check that is trying to run and hanging. Closing this PR and will re-open as two separate PR's, splitting off the CircleCI changes into their own PR. |
|
Per Glen, there has been a change in the GIthub settings that is causing this to hang and once the earlier commits are merged in this should pass okay. Ok to re-open PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168
Upgrade all usages of Ruby to 3.2.2, and all mentions of Rails to 6.1.7.6. Ran
bundle update. All tests passing.The circleci tests would no longer run after updating the Ruby version. Turns out there's an issue with the orb, as described at CircleCI-Public/browser-tools-orb#75. The workaround is to force the Chrome installation to be a specific version (114.0.5735.90) so that the chromeDrivers that the orb can install will work. Applying the workaround also ended up requiring me to specifically add in an installation of Node.js, as it would not work without Node installed. After making these changes, the circleci tests would again run and pass.
Changes to circleci/config.yml file:
"browser-tools/install-browser-tools:
chrome-version: 114.0.5735.90"