add a note about prf sorting #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Irakli Gozalishvili <[email protected]>
Closed
expede
reviewed
Nov 29, 2022
| 3. [`dag-json`](https://ipld.io/specs/codecs/dag-json/spec/) encoding MUST be used | ||
| 4. The resulting JWT MUST be [base64url](https://datatracker.ietf.org/doc/html/rfc4648#section-5) encoded per [RFC 7519] | ||
| 5. All segments MUST be joined with `.`s, per [RFC 7519](https://www.rfc-editor.org/rfc/rfc7519) | ||
| 3. Elements in `prf`s field MUST be sorted alphabetically. |
There was a problem hiding this comment.
Do we want them alphabetically, or numerically on the underlying bits?
There was a problem hiding this comment.
I guess this will be represented as a string, so UTF8 sorting makes sense 👍
expede
approved these changes
Aug 14, 2023
|
Thanks @Gozala — all good to merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Irakli Gozalishvili [email protected]