Skip to content

chore: use simpler spinner styling #4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

Muqtxdir
Copy link
Member

@Muqtxdir Muqtxdir commented Sep 9, 2024

description:

  • update icon's symbolic
  • update gnome-shell's symbolic
  • cursors
  • plymouth

screencast:

Screencast.from.2024-09-10.02-56-04.mp4

Closes: #4132

@Muqtxdir Muqtxdir marked this pull request as draft September 9, 2024 21:11
Muqtxdir and others added 4 commits November 19, 2024 00:11
* icons: Update rendered icons and symlinks

* New upstream symbolic icons list for gnome-system-monitor symbolics (#4099)

* New upstream symbolic icons list for gnome-calendar symbolics (#4087)

* New upstream symbolic icons list for evince symbolics (#4085)

* New upstream symbolic icons list for gnome-control-center symbolics (#4028)

* New upstream symbolic icons list for gnome-software symbolics (#4002)

* Update gnome-system-monitor symbolics

* Update gnome-calendar symbolics

* Update gnome-control-center symbolics

* Update gnome-software symbolics

* gnome-shell: Use button style for auth dialog list items

LP: #2080321

* build: Bump version to 24.10.4

* Update changelog

* Upload to oracular

* gnome-shell: Add missing keyboard-zwnj-symbolic icon

* Initial revamp watch standby and watch progress

* Added redesigned org.gnome.Software icon (#4157)

* Created org.gnome.Snapshot Link Targetting the camera-app icon.  (#4159)

* created symbolic links named org.gnome.Snapshot pointing to camera-app to supliment missing yaru icon for gnome-snapshot

* replace gnome-snapshot links targeting camera-app<or -symbolic>.<png or svg> with custom icon instead

* reworked org.gnome.Snapshot-symbolic

* GnomeShell: Yaruify upstream icons (#4138)

* GnomeShell: Yaruify upstream icons

* chore: optimize `actions` symbolics

* chore: optimize symbolics under `status`

---------

Co-authored-by: Muqtxdir <[email protected]>

* build(deps): bump actions/setup-python from 5.2.0 to 5.3.0 (#4150)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v5.2.0...v5.3.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fixed jitter issue in watch.ani by correcting watch.in typo in last line

* generated watch and wait ani for x11 and w32 with no jitter issue

* updated left_ptr_watch: use solid spinner bg instead of gradient to reduce noise small size

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: 3v1n0 <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Paul Kepinski <[email protected]>
Co-authored-by: Marco Trevisan (Treviño) <[email protected]>
Co-authored-by: Muqtxdir <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ochi12
Copy link
Contributor

ochi12 commented Nov 22, 2024

how do you actually do the plymouth part? it's the spinner theme right?

24 - 100%
30 - 125%
32 - 133% (kept for prev compat)
36 - 150%
42 - 175 %
48 - 200%
54 - 225%
60 - 250%
64 - 267% (kept for prev compat)
66 - 275%
72 - 300%
78 - 325%
84 - 350%
90 - 375%
96 - 400%
@Muqtxdir
Copy link
Member Author

how do you actually do the plymouth part? it's the spinner theme right?

you are correct, its the patched variant of plymouth-theme-spinner but im considering to add plymouth component that is not enabled by default in this project that can be used as reference for patching plymouth-theme-spinner assets

@3v1n0
Copy link
Contributor

3v1n0 commented Mar 13, 2025

@Muqtxdir hey, what's the status of this?

I think the spinner has been refactored in GNOME shell for 48 though

@ochi12
Copy link
Contributor

ochi12 commented Mar 17, 2025

@Muqtxdir hey, what's the status of this?

I think the spinner has been refactored in GNOME shell for 48 though

I think its kinda odd that gnome optimized by using the AdwSpinner / AdwSpinnerPaintable but forgot the part for customizability. I understand the downside of using GtkSpinner but the part where AdwSpinner is not, I just don't understand it.

Atleast this change will still take effect on the gnome-shell itself.

@3v1n0
Copy link
Contributor

3v1n0 commented Mar 17, 2025

We can still customize it in libadwaita for Ubuntu, not the best but we can.

However try to see if there's some interest upstream to support custom implementations (I doubt it)

@Muqtxdir
Copy link
Member Author

Hi guys,

sorry @3v1n0 didn't get your earlier ping in this thread, I'd suggest we try to patch the spinner implementation in libadwaita only for Ubuntu session, wdyt? ( I really don't think upstream, would be open to change to Spinner look )

@3v1n0
Copy link
Contributor

3v1n0 commented Mar 17, 2025

That's fine, I guess we'll target 25.10 at this point though, right?

@Muqtxdir
Copy link
Member Author

Sure, best to figure this out for next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nitpick] spinner: change/update the look
3 participants