Skip to content

MIR: make roles interconnected with about-mir-roles #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2025

Conversation

cpaelzer
Copy link
Collaborator

@cpaelzer cpaelzer commented Jul 3, 2025

Fixes: #91

Copy link
Collaborator

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@cpaelzer cpaelzer added the MIR For the attention of the MIR team label Jul 3, 2025
@cpaelzer cpaelzer force-pushed the mir-role-interdependency branch from 531f6ec to 31a435c Compare July 3, 2025 14:58
@setharnold
Copy link
Collaborator

LGTM +1

@cpaelzer cpaelzer force-pushed the mir-role-interdependency branch from 31a435c to 74262a8 Compare July 18, 2025 06:18
@cpaelzer
Copy link
Collaborator Author

FYI - rebased to be able to merge.

@s-makin this shows a weakness in the "mandatory reviewer" setup.
Any of https://launchpad.net/~ubuntu-mir/+members shall be sufficient, but slyon/joalif/didrocks have been selected yet Seth/Matthias/Myles/Pushkar are supposed to be on the very same permission level.
I'd add them to .github/CODEOWNERS - and some of them have to - but for example Seth is in there already and gave a LGTM. Would that have worked already if it was a formal review slot and approval?
Could you please add the other folks and ensure it works whoever said yes?

@s-makin
Copy link
Collaborator

s-makin commented Jul 21, 2025

FYI - rebased to be able to merge.

@s-makin this shows a weakness in the "mandatory reviewer" setup. Any of https://launchpad.net/~ubuntu-mir/+members shall be sufficient, but slyon/joalif/didrocks have been selected yet Seth/Matthias/Myles/Pushkar are supposed to be on the very same permission level. I'd add them to .github/CODEOWNERS - and some of them have to - but for example Seth is in there already and gave a LGTM. Would that have worked already if it was a formal review slot and approval? Could you please add the other folks and ensure it works whoever said yes?

Last time I checked in with @rkratky about this, he mentioned that Seth had yet to accept his invitation, which might be why he's still not showing on the list of requested reviewers.

Last week Robert was in discussions with IS about getting them to set up a team with the members automatically synced from Launchpad. This will be much better than having to add people manually whenever they join the team, since we can just place ownership under the team rather than individuals. In the meantime, I'm happy to add those who are missing if you can confirm their GitHub aliases (just so I don't add the wrong people).

@cpaelzer
Copy link
Collaborator Author

Last time I checked in with @rkratky about this, he mentioned that Seth had yet to accept his invitation, which might be why he's still not showing on the list of requested reviewers.

@setharnold - do you ?
To be clear - What invite exactly does Seth need to accept?

Last week Robert was in discussions with IS about getting them to set up a team with the members automatically synced from Launchpad. This will be much better than having to add people manually whenever they join the team, since we can just place ownership under the team rather than individuals.

Yes, that is a good final goal to aim for, until then let us keep the lists in sync

In the meantime, I'm happy to add those who are missing if you can confirm their GitHub aliases (just so I don't add the wrong people).

I see, checking ubuntu-project-docs/.github/CODEOWNERS I indeed see today only @slyon @setharnold @joalif @didrocks @cpaelzer

So we miss the not very active but continuous honor'y member https://launchpad.net/~doko , not sure if he wants to be bothered by every doc change.

As well as the more recent:

And speaking of all that, the AA structure now also needs codeowners to be put in.

@s-makin
Copy link
Collaborator

s-makin commented Jul 21, 2025

@setharnold - do you ? To be clear - What invite exactly does Seth need to accept?

He should have got an email -- it might have been a while ago now, so I re-invited just now.

  Let me file an MP to add that ... => [CODEOWNERS: complete active MIR team members #114](https://github.com/ubuntu/ubuntu-project-docs/pull/114)

Approved! I sent invites to pushkar and myles as well.

@s-makin s-makin merged commit defa667 into main Jul 22, 2025
1 of 3 checks passed
@s-makin s-makin deleted the mir-role-interdependency branch July 22, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MIR For the attention of the MIR team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIR - make role details reachable from the overview
3 participants