-
Notifications
You must be signed in to change notification settings - Fork 14
MIR: make roles interconnected with about-mir-roles #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
531f6ec
to
31a435c
Compare
LGTM +1 |
Fixes: #91 Signed-off-by: Christian Ehrhardt <[email protected]>
31a435c
to
74262a8
Compare
FYI - rebased to be able to merge. @s-makin this shows a weakness in the "mandatory reviewer" setup. |
Last time I checked in with @rkratky about this, he mentioned that Seth had yet to accept his invitation, which might be why he's still not showing on the list of requested reviewers. Last week Robert was in discussions with IS about getting them to set up a team with the members automatically synced from Launchpad. This will be much better than having to add people manually whenever they join the team, since we can just place ownership under the team rather than individuals. In the meantime, I'm happy to add those who are missing if you can confirm their GitHub aliases (just so I don't add the wrong people). |
@setharnold - do you ?
Yes, that is a good final goal to aim for, until then let us keep the lists in sync
I see, checking So we miss the not very active but continuous honor'y member https://launchpad.net/~doko , not sure if he wants to be bothered by every doc change. As well as the more recent:
And speaking of all that, the AA structure now also needs codeowners to be put in. |
He should have got an email -- it might have been a while ago now, so I re-invited just now.
Approved! I sent invites to pushkar and myles as well. |
Fixes: #91