Don't overwrite shell when updating user entry #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
=======================================
Coverage 85.43% 85.44%
=======================================
Files 80 80
Lines 5547 5550 +3
Branches 109 109
=======================================
+ Hits 4739 4742 +3
Misses 753 753
Partials 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adombeck
force-pushed
the
880-do-not-update-shell-and-home
branch
2 times, most recently
from
381f51a to
5cbba79
Compare
adombeck
changed the title
2 tasks
3v1n0
reviewed
Apr 21, 2025
The shell should be configurable locally and not overwritten when the user info is refreshed.
adombeck
force-pushed
the
880-do-not-update-shell-and-home
branch
from
5cbba79 to
5226dc9
Compare
|
I would like to get this merged in time for the release. |
3v1n0
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user's shell should be configurable locally and not overwritten when the user info is being refreshed.
Closes #880
UDENG-6659