Increase buffer token size as needed #1230
Open
+298
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be able to resize the buffer later, we need to have control over the file cursor otherwise it would move forward and we would not be able to retry reading the large entry. Sadly, this implies on removing the fuzz test as we can't use os.File as argument.
Although the token size is already quite large by default, we might end up in a situation where it's still not big enough, so we need to address this by increasing its size if we find one that's too large.
adombeck
reviewed
Mar 21, 2025
| @@ -51,10 +52,10 @@ type meta struct { | |||
| } | |||
|
|
|||
| // DecodePolicy parses a policy stream in registry file format and returns a slice of entries. | |||
| func DecodePolicy(r io.Reader) (entries []entry.Entry, err error) { | |||
| func DecodePolicy(f *os.File) (entries []entry.Entry, err error) { | |||
There was a problem hiding this comment.
In order to be able to resize the buffer later, we need to have control
over the file cursor otherwise it would move forward and we would not be
able to retry reading the large entry.Sadly, this implies on removing the fuzz test as we can't use os.File as
argument.
Could we do the f.Seek(0, 0) conditionally if the r io.Reader is of type *os.File, so that we're able to keep the fuzz test?
There was a problem hiding this comment.
alternatively, the fuzz test could write the fuzz data to a file (which should be in-memory for performance) and pass that to DecodePolicy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users had issues with GPOs with large entries overflowing the buffer and causing the update to fail. This fixes that by progressively increasing the expected readable token size until the maximum we can (the
bufiopackage limits this).UDENG-6434
Closes #1191