Upgrade RPC Logic #100
Comments
|
Sure thing will catch it tomorrow Frontend
Backend
|
As in uAD.ubq.fi? I think there's an issue open for it you can handle that separately because I expect that to be its own big project. It's significantly more complicated codebase.
Don't think it's necessary for anything in production currently. Besides I can't think of where it's even being used. |
I already have a pull ready for it, if you can allow the build workflow I can abuse the preview deployment and try to reproduce, either way I can add the rpc-handler as part of that PR
No probs |
|
neither audit nor onboarding actually make use of any RPC calls reviewing the code, onboarding does lean into using the MM provider which the rpc-handler would have no effect on
|
The built in RPC sucks for speed. Let's use our custom ones if its for reading data on chain. |
|
I'm mistaken anyway there are two calls, decimals and approve, my bad Will pr it rn |
What could be replaced:
I'm unsure if it's worth it but that's the only reads that are happening, thought I'd ask before firing in a PR |
|
@Keyrxng heres a follow up |
|
Last PR open in |
|
@Keyrxng seems that it's the last step before closing this out? |
|
@Keyrxng the deadline is at 2024-07-16T03:43:14.940Z |
+ Evaluating results. Please wait... |
![UbiquiBot[dev]](https://avatars.githubusercontent.com/in/257883?s=40&u=1eea9b595c7c8aa1f9dd80751aa25f169024431e&v=4){kind=avatar}
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Task | 1 | 100 |
| Issue | Comment | 7 | 0 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Sure thing will catch it tomorrow #### Frontend - onboarding - a… | 0content:
p:
count: 43
score: 1
wordValue: 0
formattingMultiplier: 0
| 0.9 | - |
I already have a pull ready for it, if you can allow the build w… | 0content:
p:
count: 41
score: 1
wordValue: 0
formattingMultiplier: 0
| 0.7 | - |
neither audit nor onboarding actually make use of any RPC calls … | 0content:
p:
count: 80
score: 1
code:
count: 7
score: 1
wordValue: 0
formattingMultiplier: 0
| 0.8 | - |
I'm mistaken anyway there are two calls, decimals and approve, m… | 0content:
p:
count: 16
score: 1
wordValue: 0
formattingMultiplier: 0
| 0.5 | - |
- https://github.com/ubiquity/onboard.ubq.fi/blob/66b2bcbb3ca21f… | 0content:
ul:
count: 86
score: 1
li:
count: 86
score: 1
wordValue: 0
formattingMultiplier: 0
| 0.9 | - |
Last PR open in [`permit-generation` ](https://github.co… | 0content:
p:
count: 5
score: 1
a:
count: 1
score: 1
code:
count: 1
score: 1
wordValue: 0
formattingMultiplier: 0
| 0.3 | - |
@0x4007 yeah just need this [PR](https://github.com/ubiquibot/pe… | 0content:
p:
count: 13
score: 1
a:
count: 1
score: 1
wordValue: 0
formattingMultiplier: 0
| 0.2 | - |
[ 6.78 WXDAI ]
@0x4007
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Specification | 1 | 4.4 |
| Issue | Comment | 4 | 2.38 |
Conversation Incentives
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
@Keyrxng you think you can swap out the logic in the repos using… | 4.4content:
p:
count: 44
score: 1
em:
count: 6
score: 0
wordValue: 0.1
formattingMultiplier: 1
| 1 | 4.4 |
As in uAD.ubq.fi? I think there's an issue open for it you can h… | 10content:
p:
count: 50
score: 1
wordValue: 0.2
formattingMultiplier: 1
| 0.2 | 2 |
The built in RPC sucks for speed. Let's use our custom ones if i… | 3.8content:
p:
count: 19
score: 1
wordValue: 0.2
formattingMultiplier: 1
| 0.1 | 0.38 |
@Keyrxng heres a follow up | 1content:
p:
count: 5
score: 1
wordValue: 0.2
formattingMultiplier: 1
| - | - |
@Keyrxng seems that it's the last step before closing this out? | 2.2content:
p:
count: 11
score: 1
wordValue: 0.2
formattingMultiplier: 1
| - | - |
@Keyrxng you think you can swap out the logic in the repos using the old version with your package? I'm not sure which all have it off hand but I assume onboard, audit, and pay have this logic.
Originally posted by @pavlovcik in ubiquity/rpc-handler#3 (comment)
The text was updated successfully, but these errors were encountered: