-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade rpc logic #3
Conversation
@pavlovcik just the finishing touches I was working on for the other PR |
I can't really tell the difference when I run this. Whats the purpose of this in the scope of getting the new RPCs working? What was the problem with the original deliverable? |
In essence nothing other than now it's not one singular websocket endpoint being used when not MM connected. The UI is still using the MM provider for the most part but thought it prudent to upgrade the RPC logic here too seeing as it's happening across the board |
It seems like there's a lot of out of scope changes to the react code. They should be done in a separate pull |
I'll open a new PR with the |
It shaves about 1-1.5 secs off of the loading time memo-izing (i mean the time it takes for the APR to display) |
|
45d9e80
to
65fec90
Compare
@0x4007 the trouble with this is that So this would benefit from Having said that, on the prod instance right now I can repro a bunch of call failures just by accessing credits. |
Oh I'm surprised you are working on this codebase. I almost think we should toss it out and start fresh. Anyways if you are making a lot of changes, consider doing it across several tightly scoped pulls. |
ubiquity/.github#100 (comment) This is the last place I believe that Other than memo-izing these are the only changes needed as a proxied provider will handle retry etc. I removed the dirty commits I made memo-izing in this PR previously so it's cleaner
The RPCs are not used in audit, neither of the two functions which use |
I am surprised that audit isn't using RPCs. @rndquu rfc |
as far as I can tell audit is relying on the DB having all of the data needed other than what can be taken directly from parsing the repo. Because of this issue I adjusted |
Yes, https://github.com/ubiquity/audit.ubq.fi relies on a DB right now since all permits (at least in bot v2) are saved in a DB right now and it's easier to fetch them from a DB instead of parsing etherscan/github/etc... Besides there's an ongoing task to save already generated (i.e. old) permits to a DB to make the |
Relates to #2
rpc-handler
ignore the background handler calls I just swapped out the providers for QA
works as expected but does require multi dynamic import (which I now see the fix for shortening the rpc-handler import path by exporting one file that handles multi-import like the way the hook does here)