feat: multiply conv reward with priority for higher reward

[ishowvel]

Resolves #175

[ishowvel]

/help

[ubiquity-os-beta]

Available Commands

Command	Description	Example
/help	List all available commands.	/help
/allow	Allows the user to modify the given label.	/allow @user1 label
/query	Returns the user's wallet, access, and multiplier information.	/query @UbiquityOS
/start	Assign yourself to the issue.	/start
/stop	Unassign yourself from the issue.	/stop
/wallet	Register your wallet address for payments.	/wallet ubq.eth

[ishowvel]

heres the qa

[ishowvel]

@gentlementlegen please review this 🙏

[ubiquity-os-beta]

@ishowvel, this task has been idle for a while. Please provide an update.

[gentlementlegen]

@ishowvel You should add Jest tests to your pull-request.

Here is my latest QA:

The decimals should not look like this. Also, I am confused about the total here. Can you walk me through the calculations?

[ishowvel]

After the total formatted reward is calculated, the priority level is multiplied to the reward for that specific comment, this all happens in the formatting evaluation.
Then after the reward is passed to content evaluation to calc and multiply it with the relevance for that specific comment.

The only change here is adding a multiplication of the priority level to the formatting reward calculation

[ishowvel]

the total itself is not multiplied but the specification and comment incentives are

[ishowvel]

for jest testing, no mock result has ever contained the "priority" key. Can you help me find a way to make the mock results for this?
all results starting at the formatting module would need to be changed

[0x4007]

Just copy the priority level names? Our config is public you can see all of them .ubiquity-os repo

[ishowvel]

Just copy the priority level names? Our config is public you can see all of them .ubiquity-os repo

There are 100's and 100's of results

[ishowvel]

https://github.com/ubiquity-os-marketplace/text-conversation-rewards/blob/development/tests%2F__mocks__%2Fresults%2Fformatting-evaluator-results.json

[0x4007]

There's five priority levels

[ishowvel]

I am talking about the results, each result object would need to be edited to have an extra priority key and the total and reward values would need to be edited

[ishowvel]

Done!

[ishowvel]

All tests that failed, failed because of not supporting this feature. So I just added support in all of them

[ishowvel]

@gentlementlegen can you please review these changes? Thank you!

[ishowvel]

Any updates?

[ishowvel]

@0x4007 can you review this as you have created the specification, gentlemengen may be busy

[gentlementlegen]

@ishowvel Sorry I have been extremely busy yes, I'll try to have a look today. In the meantime please fix the conflicts.

[ubiquity-os-beta]

@ishowvel, this task has been idle for a while. Please provide an update.

[ishowvel]

Currently out for a university, will work on this task in a few hours

[ishowvel]

idk why the tests keep failing even without the changes present in this pull request, i made a branch and force reset it to this repo's dev branch, heres the test

[gentlementlegen]

@ishowvel tests don't pass because the import types don't match, I think @octokit/rest is imported when it should be @octokit/core within the tests.

[ishowvel]

@gentlementlegen @octokit/core is imported, this has become a major blocker for me as i cant debug my other pr without working tests

[ishowvel]

tests even fail on a fresh clone of this repository

[gentlementlegen]

@ishowvel merge the development branch into this one.

[ishowvel]

Tests are passing 🎉 🎉 🎉

[ubiquity-os-beta]

@ishowvel, this task has been idle for a while. Please provide an update.