Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kdTree.js #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update kdTree.js #5

wants to merge 1 commit into from

Conversation

philogb
Copy link

@philogb philogb commented Oct 30, 2013

When content.length is less than maxNodes then that line would fail.

When `content.length` is less than `maxNodes` then that line would fail.
@aemkei
Copy link
Member

aemkei commented Oct 31, 2013

Shouldn't it be:

if (
  bestNodes.content[i] && 
  bestNodes.content[i][0]
) {
  ...
}

?

@philogb
Copy link
Author

philogb commented Oct 31, 2013

The more checks the better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants