Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds typing support to
filecache
, turning it into a type-safe library.It is type-checked using mypy:
It also passes all tests:
This implementation transfers all the caching logic into the
CachedFileCacheCallable
class, which is callable and acts like a function. This makes thefilecache
decorator a lot more clean.The typing implementation is based on https://github.com/maxfischer2781/asyncstdlib/blob/master/asyncstdlib/_lrucache.pyi. It makes the
filecache
decorator type-check on both plain functions and methods.Feel free to change as desired, specially variable naming.