refactor, better assistant #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for openduck ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| <button | ||
| className={`orb-button min-w-32 bg-blue-500 hover:bg-blue-600 text-white rounded-full p-4 cursor-pointer shadow-lg transform transition-transform duration-300 ease-in-out ${ | ||
| !userName && "opacity-50 cursor-not-allowed" | ||
| className={`orb-button w-48 h-48 bg-blue-500 hover:bg-blue-600 text-white rounded-full p-4 cursor-pointer shadow-lg transform transition-transform duration-300 ease-in-out flex items-center justify-center text-2xl ${ |
There was a problem hiding this comment.
- This ESLint rule specifically enforces the usage of shorthand Tailwind CSS classnames, which promotes consistency in coding style by ensuring developers use Tailwind's optimized shorthand syntax where applicable. For instance, converting individual padding classes to a single shorthand
p-2class in the provided example. - It helps in reducing the overall file size of the stylesheets by condensing multiple class declarations into fewer shorthand declarations. This can contribute to faster load times and better performance of web applications.
Suggested change
| className={`orb-button w-48 h-48 bg-blue-500 hover:bg-blue-600 text-white rounded-full p-4 cursor-pointer shadow-lg transform transition-transform duration-300 ease-in-out flex items-center justify-center text-2xl ${ | |
| className={`orb-button size-48 bg-blue-500 hover:bg-blue-600 text-white rounded-full p-4 cursor-pointer shadow-lg transform transition-transform duration-300 ease-in-out flex items-center justify-center text-2xl ${ |
| <button | ||
| className={`orb-button min-w-32 bg-blue-500 hover:bg-blue-600 text-white rounded-full p-4 cursor-pointer shadow-lg transform transition-transform duration-300 ease-in-out ${ | ||
| !userName && "opacity-50 cursor-not-allowed" | ||
| className={`orb-button w-48 h-48 bg-blue-500 hover:bg-blue-600 text-white rounded-full p-4 cursor-pointer shadow-lg transform transition-transform duration-300 ease-in-out flex items-center justify-center text-2xl ${ |
There was a problem hiding this comment.
- This ESLint rule specifically targets the migration process from Tailwind CSS v2 to v3 by identifying class names that have either become obsolete or have updated naming conventions in the newer version, making the upgrade smoother and ensuring that the project's styling remains consistent without manual checks.
- By automatically detecting and suggesting fixes for deprecated or changed class names, this rule not only reduces the time needed for developers to manually search and replace outdated classes but also minimizes the risk of errors that could lead to inconsistent UI/UX throughout the application.
Suggested change
| className={`orb-button w-48 h-48 bg-blue-500 hover:bg-blue-600 text-white rounded-full p-4 cursor-pointer shadow-lg transform transition-transform duration-300 ease-in-out flex items-center justify-center text-2xl ${ | |
| className={`orb-button w-48 h-48 bg-blue-500 hover:bg-blue-600 text-white rounded-full p-4 cursor-pointer shadow-lg transition-transform duration-300 ease-in-out flex items-center justify-center text-2xl${ |
| </h1> | ||
| <AudioCall callObject={callObject} /> | ||
| <div className="flex-grow flex items-start"> |
There was a problem hiding this comment.
- This ESLint rule specifically targets the migration process from Tailwind CSS v2 to v3 by identifying class names that have either become obsolete or have updated naming conventions in the newer version, making the upgrade smoother and ensuring that the project's styling remains consistent without manual checks.
- By automatically detecting and suggesting fixes for deprecated or changed class names, this rule not only reduces the time needed for developers to manually search and replace outdated classes but also minimizes the risk of errors that could lead to inconsistent UI/UX throughout the application.
Suggested change
| <div className="flex-grow flex items-start"> | |
| <div className="grow flex items-start"> |
| "role": "system", | ||
| "content": system_prompt, | ||
| } | ||
| # new_message = {"role": "user", "content": transcription} |
|
|
||
| # NOTE(zach): retries | ||
| response = None | ||
| for _retry in range(3): |
There was a problem hiding this comment.
not related to this PR but just wondering if the retries help? does it happen often that the openai API fails but then works again on retry? or is it a moderations thing?
There was a problem hiding this comment.
I'm not sure tbh, but I implemented this because things were flagged as moderation violations that clearly shouldn't have been
matthewkennedy5
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Description
log_eventfunction to log events with metadata and audio to the database.ResponseAgentclass for handling audio transcription, normalization, TTS, and response generation.ResponseAgentand added a new endpoint for podcast room creation.Changes walkthrough
db.py
Add event logging functionality with audio supportopenduck-py/openduck_py/logging/db.py
log_eventto log various events with optionalmetadata and audio.
metadata, and latency.
response_agent.py
Implement ResponseAgent for audio processing and response generationopenduck-py/openduck_py/response_agent.py
ResponseAgentclass to handle audio responses.text-to-speech (TTS) generation.
using GPT models.
voice.py
Refactor voice router to use ResponseAgent and add podcast endpointopenduck-py/openduck_py/routers/voice.py
ResponseAgentclass.response_agent.py./start/podcastto create a podcast room.page.tsx
Update UI elements and layout in the main pageweb/src/app/page.tsx
__init__.py
Update environment variable handling with default valuesopenduck-py/openduck_py/settings/init.py
strings if not set.
daily.py
Ensure process termination after leaving daily eventopenduck-py/openduck_py/utils/daily.py
termination.
🔍 Anti-patterns Detected:
openduck-py/openduck_py/response_agent.py
openduck-py/openduck_py/routers/voice.py
web/src/app/page.tsx
💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.