-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Personas config and tts options #125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
151
to
162
kwargs=dict( | ||
room_url=room_info["url"], | ||
username="Vikram (AI)", | ||
prompt=f"{request.prompt}.txt", | ||
voice_id=ELEVENLABS_VIKRAM, | ||
speak_first=True, | ||
username=personas[request.prompt]["username"], | ||
prompt=personas[request.prompt]["prompt"], | ||
tts_config=TTSConfig( | ||
provider=personas[request.prompt]["voice_provider"], | ||
voice_id=personas[request.prompt]["voice"], | ||
), | ||
speak_first=personas[request.prompt]["speak_first"], | ||
context=context, | ||
room_id=room_info["id"], | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
kwargs=dict( | |
room_url=room_info["url"], | |
username="Vikram (AI)", | |
prompt=f"{request.prompt}.txt", | |
voice_id=ELEVENLABS_VIKRAM, | |
speak_first=True, | |
username=personas[request.prompt]["username"], | |
prompt=personas[request.prompt]["prompt"], | |
tts_config=TTSConfig( | |
provider=personas[request.prompt]["voice_provider"], | |
voice_id=personas[request.prompt]["voice"], | |
), | |
speak_first=personas[request.prompt]["speak_first"], | |
context=context, | |
room_id=room_info["id"], | |
), | |
kwargs={ | |
room_url=room_info["url"], | |
username=personas[request.prompt]["username"], | |
prompt=personas[request.prompt]["prompt"], | |
tts_config=TTSConfig( | |
provider=personas[request.prompt]["voice_provider"], | |
voice_id=personas[request.prompt]["voice"], | |
), | |
speak_first=personas[request.prompt]["speak_first"], | |
context=context, | |
room_id=room_info["id"], | |
}, |
zachwe
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Description
personas
dictionary to manage different voice personas, each with its own TTS configuration and prompt.response_agent.py
.create_room_and_start
,connect_daily
, andrun_connect_daily
functions inrouters/voice.py
to utilize the newpersonas
configuration andtts_config
parameter.Changes walkthrough
response_agent.py
Enhance TTS Configuration for Multiple Providers
openduck-py/openduck_py/response_agent.py
voice_id
asvoice
orvoice_name
parameter based on the provider.
voice.py
Implement Personas Configuration and TTS Options
openduck-py/openduck_py/routers/voice.py
personas
dictionary to store configurations for differentpersonas.
create_room_and_start
to usepersonas
config for setting upvoice and prompt options.
connect_daily
andrun_connect_daily
functions to accepttts_config
instead ofvoice_id
.🔍 Anti-patterns Detected:
openduck-py/openduck_py/routers/voice.py
💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.