Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt changes and noise cancellation #116

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

matthewkennedy5
Copy link
Contributor

@matthewkennedy5 matthewkennedy5 commented Apr 1, 2024

User description

  • Added "noise-cancellation" in Daily, which uses KRISP to filter out background noise. Might help with filtering out background voices
  • Some changes to the comedy prompt
  • some settings.py refactors

Description

  • Introduced a TEMPERATURE variable in settings for dynamic configuration of the conversation temperature.
  • Refactored chat model parameters to use a new ChatModels type annotation and updated the default chat model.
  • Added noise cancellation feature to the Daily call settings in the voice router.
  • Removed an unused Switch component from the front-end code and implemented noise cancellation in the audio input settings.
  • Updated the comedy prompt to better suit a humorous conversation in the style of Kevin Hart, removing non-spoken instructions.

Changes walkthrough

Relevant files
Enhancement
response_agent.py
Refactor temperature setting and chat model parameter                   

openduck-py/openduck_py/response_agent.py

  • Replaced hardcoded temperature value with TEMPERATURE variable from
    settings.
  • Changed chat_model parameter default value to CHAT_MODEL instead of
    CHAT_MODEL_GPT4.
  • +3/-3     
    voice.py
    Add noise cancellation feature to voice router                                 

    openduck-py/openduck_py/routers/voice.py

    • Added noise cancellation feature to Daily call settings.
    +2/-1     
    settings.py
    Introduce temperature variable and refactor chat models               

    openduck-py/openduck_py/settings.py

  • Introduced TEMPERATURE variable for dynamic temperature configuration.
  • Replaced individual chat model variables with ChatModels type
    annotation.
  • Changed default CHAT_MODEL to "azure/gpt-35-turbo-deployment".
  • Set LOG_TO_S3 to False.
  • +7/-5     
    page.tsx
    Remove unused component and add noise cancellation                         

    web/src/app/page.tsx

  • Removed unused Switch component.
  • Added noise cancellation processor to callObject's audio input
    settings.
  • +7/-25   
    comedy.txt
    Update comedy prompt for humorous conversations                               

    openduck-py/openduck_py/prompts/comedy.txt

  • Updated comedy prompt to reflect a humorous conversation in the style
    of Kevin Hart.
  • Removed instructions that are not typically spoken in a voice
    conversation.
  • +3/-4     
    💡 Usage Guide

    Checking Your Pull Request

    Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

    Talking to CodeAnt AI

    Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

    @codeant-ai ask: Your question here
    

    This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

    Check Your Repository Health

    To analyze the health of your code repository, visit our dashboard at app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

    Copy link

    vercel bot commented Apr 1, 2024

    The latest updates on your projects. Learn more about Vercel for Git ↗︎

    Name Status Preview Updated (UTC)
    openduck ✅ Ready (Inspect) Visit Preview Apr 1, 2024 5:55pm

    @codeant-ai codeant-ai bot added enhancement New feature or request bug_fix labels Apr 1, 2024
    Copy link
    Contributor

    @williamluer williamluer left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Do you have samples comparing the audio outputs with and without noise cancellation?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    bug_fix enhancement New feature or request
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    3 participants