Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove daily service from docker-compose, and remove ml_router from the web service #104

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

matthewkennedy5
Copy link
Contributor

@matthewkennedy5 matthewkennedy5 commented Mar 26, 2024

User description

We want to keep the ML endpoints in the ML service so we avoid reloading the models every time we create a new process. Right now the models were getting loaded twice, once in the ML service and once in the Web service.

Also we can delete the daily service from docker-compose, since we want to develop on the openduck version.


Description

  • Removed the ml_router from the main application to avoid loading ML models in the web service.
  • Deleted the daily service from the docker-compose file to focus on the openduck version development.
  • Updated the ml service port from 8000 to 8001 to prevent port conflicts.

Changes walkthrough

Relevant files
Enhancement
main.py
Remove ML router from main application                                                 

openduck-py/openduck_py/routers/main.py

  • Removed the inclusion of ml_router from the main application.
+0/-2     
Configuration changes
docker-compose.yml
Update docker-compose configuration                                                       

docker-compose.yml

  • Removed the daily service from the docker-compose file.
  • Changed the port for the ml service from 8000 to 8001.
  • +2/-16   
    💡 Usage Guide

    Checking Your Pull Request

    Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

    Talking to CodeAnt AI

    Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

    @codeant-ai ask: Your question here
    

    This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

    Check Your Repository Health

    To analyze the health of your code repository, visit our dashboard at app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

    Copy link

    vercel bot commented Mar 26, 2024

    The latest updates on your projects. Learn more about Vercel for Git ↗︎

    Name Status Preview Comments Updated (UTC)
    openduck ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 7:01pm

    @codeant-ai codeant-ai bot added enhancement New feature or request configuration changes labels Mar 26, 2024
    @@ -1,5 +1,4 @@
    UBERDUCK_API_HOST=localhost:8000/audio/response
    ML_API_URL=http://openduck_ml_1:8001
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    let's keep this. Set it to ML_API_URL=http://localhost:8000 by default

    it's a good abstraction for when they need to be scaled independently

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    2 participants