Xcode 16 Support #316
Merged
Xcode 16 Support #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made minor updates required to build/run on Xcode 16. Only one change was required to handle UIApplication.openUrl
Changes
ApplicationLaunching
UIApplication's open(url...) method signature changed. Since the ApplicationLaunching protocol redefined this method and we had a UIApplication extension conforming to ApplicationLaunching, this broke.
To fix this, open(url) was changed to launch(url) and the method is not called internally in the extension.
Testing
Manual Testing
Manually tested both inApp and native auth on simulator and physical devices
Unit tests
Mocks + unit tests were updated