Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt parameter for native auth #313

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

mohssenfathi
Copy link
Contributor

Description

Adding support for the prompt OAuth parameter when executing native auth. We do not want to support the login option when launching the native 1P app, so this is removed before launching. Only the consent option should work for native auth.

Testing

Unit Tests

Added unit tests to ensure the login prompt value is not sent for native requests

Manual Testing

  1. Run the sample app
  2. Set Destination to Native
  3. Toggle Always ask for Login and Always ask for Consent to on
  4. Verify the native app was launched and only consent was required, not login

@mohssenfathi mohssenfathi marked this pull request as ready for review August 27, 2024 18:49
@mohssenfathi mohssenfathi merged commit af5fd62 into uber:2.x Aug 27, 2024
4 checks passed
@mohssenfathi mohssenfathi deleted the native-prompt branch August 27, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants