Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop min OS version to iOS 14 #309

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Drop min OS version to iOS 14 #309

merged 1 commit into from
Jul 23, 2024

Conversation

mohssenfathi
Copy link
Contributor

Description

The current min iOS version defined in the Package file is v15. The only API restricting this is UIButton.Configuration. This PR provides a fallback for the UIButton configuration and drops the iOS version to v14.

Changes

Package.swift

  • Min OS version v15 -> v14

UberButton

  • Marked extension UIButton.Configuration as @available(iOS 15...)
  • Added code to configure UIButton using old APIs compatible with iOS 14-

@mohssenfathi mohssenfathi marked this pull request as ready for review July 23, 2024 17:17
@mohssenfathi mohssenfathi merged commit 455f578 into uber:2.x Jul 23, 2024
4 checks passed
@mohssenfathi mohssenfathi deleted the min-os branch July 23, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants