Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement prompt for re-login/consent #308

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

mohssenfathi
Copy link
Contributor

Description

Implements the OpenID prompt query parameter to allow the integrating client to force either re-login or re-consent when issuing the authorize request. Details on the API here.
Note: Backend currently only supports login and consent parameters for inApp auth only. In the future we may add support for other parameters.

Changes

Prompt

A new OptionSet that defines which prompt parameters to send to the authorize request. Multiple values are supported, they will be sent space delimited and will be url encoded in the requests query parameters.

AuthorizeRequest

Updated the AuthorizeRequest to accept prompt as a parameter. If supplied it will send it as an additional query parameter.

AuthorizationCodeAuthProvider

Also added prompt as a parameter here, which will get injected into AuthorizeRequest for inApp auth only.

Testing

  • Added unit tests to ensure parameters were being sent correctly
  • Added support for setting prompt values to the sample app
  • Manually tested using sample app:
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-02.at.09.03.58.mp4

@mohssenfathi mohssenfathi marked this pull request as ready for review July 2, 2024 20:12
@mohssenfathi mohssenfathi merged commit 815673f into uber:2.x Jul 2, 2024
4 checks passed
@mohssenfathi mohssenfathi deleted the authorize-prompt branch July 2, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants