fix(test): set PartitionDiscoveryIntervalMs in the consumer integration subscription - #541
Merged
behinddwalls merged 2 commits intoAug 7, 2026
Conversation
…on subscription Without it the field defaults to 0 and managePartitions panics on time.NewTicker(0), hanging the test until the 300s timeout. #528 added the field and updated the messagequeue integration tests, but missed this hand-built SubscriptionConfig.
roychying
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
August 7, 2026 00:35
behinddwalls
approved these changes
Aug 7, 2026
behinddwalls
temporarily deployed
to
stack-rebase
August 7, 2026 01:09 — with
GitHub Actions
Inactive
behinddwalls
deleted the
chenghan.ying/fix-consumer-partition-discovery-interval
branch
August 7, 2026 01:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#528 added
SubscriptionConfig.PartitionDiscoveryIntervalMsand updated the call sites intest/integration/extension/messagequeue/mysql/queue_test.go, but missed the hand-builtSubscriptionConfigliteral in the consumer integration suite. The field stays0, somanagePartitionscalls:which panics with non-positive interval for NewTicker (platform/extension/messagequeue/mysql/subscriber.go:490). The subscriber goroutine dies and the test hangs until the 300s timeout.
Test Plan
Issue